Ed Avis
Ed Avis
That code snippet is a trivial example. I agree, you wouldn't actually write that. But it does happen quite a lot in real code that you need to test a...
Indeed, why do you think that after 25 years of Perl programming I only just now became aware of this shortcut...
I agree that `if (/foo/) { s/foo/x/ }` can be an anti-pattern, and 99% of the time it's better to just do the replacement. Nonetheless it's sometimes useful, which must...
The policy has a few false positives because there are various ways you can 'check' the return value of an eval, and only the simplest ones are covered. The original...
See section 'Exception Handling' in perl5140delta.
Ah, I wasn't aware that Perl::Critic supported such old perls. 5.6.1 is a very conservative choice given that the earliest supported perl is 5.14, that installations who don't want the...
Could I ask the Perl::Critic maintainers to revisit this bug report now that a few more years have passed? The underlying problem with $@ that made it unsafe to check...
More than twelve years have passed since the release of perl 5.14, which fixes the issue that this policy addresses. I believe it is time to retire the policy or...