displaycal-py3 icon indicating copy to clipboard operation
displaycal-py3 copied to clipboard
verified publisher icon eoyilmaz

Replace the ``wexpect.py`` with the latest release of ``Wexpect``

Open eoyilmaz opened this issue 4 years ago • 2 comments

Replace the wexpect.py with the latest release of Pexpect. I'm not very familiar with this module, and there is no comment in the code on why we have a wexpect.py instead of using the PyPI version of Pexpect. Reading the module documentation seems that this module is a modified version of a very old version of Pexpect. Using the modern version of Pexpect would benefit the code and possibly make the modifications obsolete.

eoyilmaz avatar Feb 20 '22 10:02 eoyilmaz

I think that's because of offering windows compatibility. https://pexpect.readthedocs.io/en/stable/overview.html#windows

p5k369 avatar Mar 28 '22 19:03 p5k369

Apparently there is a PyPI version of Wexpect and it is completely written from scratch, and it is a drop in replacement. I tried using it but until we fix #367 it is not going to run properly, but it is promissing.

eoyilmaz avatar Jun 05 '24 12:06 eoyilmaz