enzyme icon indicating copy to clipboard operation
enzyme copied to clipboard

refactor: flatten the try catch block.

Open mrdulin opened this issue 2 years ago • 4 comments

mrdulin avatar Aug 03 '23 07:08 mrdulin

Codecov Report

Patch coverage has no change and project coverage change: -0.57% :warning:

Comparison is base (3a7701c) 96.42% compared to head (0c664aa) 95.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
- Coverage   96.42%   95.85%   -0.57%     
==========================================
  Files          49       43       -6     
  Lines        4332     3475     -857     
  Branches     1156      942     -214     
==========================================
- Hits         4177     3331     -846     
+ Misses        155      144      -11     

see 10 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 03 '23 07:08 codecov[bot]

Thanks! Could you explain why this is an improvement?

ljharb avatar Aug 03 '23 19:08 ljharb

@ljharb Sorry, I don't know what kind of explaination you want. I think I already did. And the code explains itself.

mrdulin avatar Aug 04 '23 05:08 mrdulin

Why is a flattened try/catch block better?

Neither the code, nor you, have explained that.

ljharb avatar Aug 04 '23 19:08 ljharb