enzyme icon indicating copy to clipboard operation
enzyme copied to clipboard
verified publisher icon enzymejs

Remove Karma flakiness by providing browser shims

Open lelandrichardson opened this issue 8 years ago • 4 comments

This fixes the travis karma flakiness, and removes the allowed failure. This does this by adding in airbnb-browser-shims to the karma tests so that we don't have to worry about which version of chrome they are running on.

lelandrichardson avatar Sep 16 '17 18:09 lelandrichardson

This appears to have not actually fixed the flakiness.... so it seems like this is not the reason for the karma flakiness :/

lelandrichardson avatar Sep 16 '17 20:09 lelandrichardson

@lelandrichardson it did fix flakiness caused by lack of polyfills,it just didn't fix the other cause of flakiness,some tests appear to cause a full page reload. This should still be merged

nfcampos avatar Sep 26 '17 19:09 nfcampos

@nfcampos any thoughts on how to fix the page reload issue? It'd be nice to fix karma in a single PR if possible.

lelandrichardson avatar Sep 30 '17 21:09 lelandrichardson

Rebased this on top of #1096.

ljharb avatar Aug 07 '18 07:08 ljharb