enzyme Remove travis allowed failure

It passes now. When was this failing?

Aug 29 '17 18:08 nfcampos

It failed consistently on my fork. I think it's flaky.

Aug 29 '17 18:08 ljharb

@ljharb hmm, do you have a link to a travis build where it failed? if it does indeed still fail it might also affect users

Aug 31 '17 18:08 nfcampos

@nfcampos https://travis-ci.org/ljharb/enzyme/builds/264637300 and https://travis-ci.org/ljharb/enzyme/jobs/264642606

Sep 01 '17 00:09 ljharb

https://travis-ci.org/airbnb/enzyme/jobs/270638186 is another one (i'm going to rerun it, so i'll paste the failure output here)

> karma start "--single-run"
01 09 2017 00:17:57.417:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/
01 09 2017 00:17:57.422:INFO [launcher]: Launching browsers Chrome_travis, Firefox with unlimited concurrency
01 09 2017 00:17:57.435:INFO [launcher]: Starting browser Chrome
01 09 2017 00:17:57.499:INFO [launcher]: Starting browser Firefox
01 09 2017 00:18:05.292:INFO [Chromium 59.0.3071 (Ubuntu 0.0.0)]: Connected on socket wS3NuuVAfWAGMpxeAAAA with id 30455731
01 09 2017 00:18:08.434:INFO [Firefox 50.0.0 (Linux 0.0.0)]: Connected on socket zA4jW4zNrl80EpZwAAAB with id 7583193
................................................................................
................................................................................
................................................................................
..............................................
ERROR: 'Warning: render(): Rendering components directly into document.body is discouraged, since its children are often manipulated by third-party scripts and browser extensions. This may lead to subtle reconciliation issues. Try rendering into a container element created for your app.'
......
ERROR: 'Warning: render(): Rendering components directly into document.body is discouraged, since its children are often manipulated by third-party scripts and browser extensions. This may lead to subtle reconciliation issues. Try rendering into a container element created for your app.'
................................................................................
................................................................................
................................................................................
................................................................................
......................................
Chromium 59.0.3071 (Ubuntu 0.0.0): Executed 650 of 656 (skipped 6) SUCCESS (2.119 secs / 1.607 secs)
Chromium 59.0.3071 (Ubuntu 0.0.0) ERROR
  Some of your tests did a full page reload!
Chromium 59.0.3071 (Ubuntu 0.0.0): Executed 650 of 656 (skipped 6) ERROR (2.149 secs / 1.607 secs)
................................................................................
................................................................................
................................................................................
..............................................
Firefox 50.0.0 (Linux 0.0.0) ERROR: 'Warning: render(): Rendering components directly into document.body is discouraged, since its children are often manipulated by third-party scripts and browser extensions. This may lead to subtle reconciliation issues. Try rendering into a container element created for your app.'
......
Firefox 50.0.0 (Linux 0.0.0) ERROR: 'Warning: render(): Rendering components directly into document.body is discouraged, since its children are often manipulated by third-party scripts and browser extensions. This may lead to subtle reconciliation issues. Try rendering into a container element created for your app.'
................................................................................
................................................................................
................................................................................
................................................................................
......................................
Firefox 50.0.0 (Linux 0.0.0): Executed 650 of 656 (skipped 6) SUCCESS (5.344 secs / 3.556 secs)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test:karma: `karma start "--single-run"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] test:karma script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2017-09-01T00_18_20_995Z-debug.log

Sep 01 '17 00:09 ljharb

@ljharb hey, so some of them failed with ReferenceError: Set is not defined, because they ran on travis workers with an older version of Chrome installed (v37) which does not have Set. For that reason I think we should add babel-polypill to the karma tests, I'll add a commit here doing that.

This one that you posted the output of here failed because some of the tests did a full page reload, that I don't understand how it could happen only sometimes...

Sep 04 '17 10:09 nfcampos

Let's please not use babel-polyfill for anything; we should be using airbnb-browser-shims. Thanks for the research tho, that helps!

Sep 05 '17 04:09 ljharb

I've rebased this; I suspect all the karma tests still fail.

I've rebased #1119 on top of this, as well.

Aug 07 '18 07:08 ljharb