oyente icon indicating copy to clipboard operation
oyente copied to clipboard

Remove global variables, use proper class/OOP encapsulation

Open vietlq opened this issue 6 years ago • 1 comments

The file and some files have quite a few global variables:

https://github.com/melonproject/oyente/blob/3fc108ca550aa5270ea5368fdb685b94f0e17450/oyente/symExec.py

Global variables introduce unnecessary complexity and signal poor design/security. This can be solved by proper OOP encapsulation and treat them as class data members. This also allows you to run multiple verifiers in parallel within the same Python process.

vietlq avatar Apr 26 '18 13:04 vietlq

IMO this should be completely rewritten from python to golang, or include mult-threaded processing.

bonedaddy avatar Apr 29 '18 17:04 bonedaddy