melonjs icon indicating copy to clipboard operation
melonjs copied to clipboard

In the docs: Missing tokens.conf in deployment.json (example for Mainnet)

Open gorillafund opened this issue 4 years ago • 1 comments

Hi Melon-Team,

By playing with the examples from the Documentation I experienced some difficulties. I think it would be easier if the examples are working out of the box. Following suggestions:

  1. In the deployment.json for the Mainnet the tokens.conf-object is missing. (https://melonjs.melonprotocol.com/building-blocks/environment/mainnet) (on the testnet it is there).

  2. In the constructor-call for the DeployedEnvironment (https://melonjs.melonprotocol.com/building-blocks/environment) the network-ID is missing.

Best regards,

JS

gorillafund avatar May 21 '20 14:05 gorillafund

Hi @gorillafund - I added the complete deployment file to fix 1) above. Waiting on one thing before i push the fix for 2). Thanks for flagging!

erin-koen avatar Jun 01 '20 18:06 erin-koen