fastquant icon indicating copy to clipboard operation
fastquant copied to clipboard

[FEATURE] adapt one date format

Open jpdeleon opened this issue 4 years ago • 2 comments

fastquant module uses "%Y-%m-%d" date format whereas disclosures uses "%m-%d-%Y". We should adapt only one format and I prefer the second one because it is more natural.

Note however that datetime.datetime used in several parts of the code adapts the prior format.

jpdeleon avatar May 05 '20 12:05 jpdeleon

ahhhh I actually find the first one to be more common :( Although, don't feel super strongly about it so don't mind either implementation.

Do note that our readme has used "%Y-%m-%d" for while so our users are probably more used to it by now.

enzoampil avatar May 13 '20 06:05 enzoampil

Ok, let’s adapt the first format. It be great to implement #80 to update notebooks automatically.

jpdeleon avatar May 14 '20 23:05 jpdeleon