mp4v2 icon indicating copy to clipboard operation
mp4v2 copied to clipboard

Add the MP4V2_ prefix to CMake options

Open corporateshark opened this issue 2 years ago • 2 comments

When this library is a part of another CMake-based project, global options BUILD_SHARED and BUILD_UTILS interfere with other projects.

Renamed both CMake options as follows:

MP4V2_BUILD_SHARED
MP4V2_BUILD_UTILS

corporateshark avatar Apr 03 '23 00:04 corporateshark

This will also causes the cmake-gui interface to group the options together under an MP4V2 heading. Right now they're grouped under "BUILD" which doesn't make sense (particularly when used as a subproject).

Before:

image

After:

image

ferdnyc avatar Feb 27 '24 22:02 ferdnyc

(Although, honestly, BUILD_SHARED should probably be replaced with support for the built-in CMake variable BUILD_SHARED_LIBS.)

ferdnyc avatar Feb 27 '24 22:02 ferdnyc