map-machine icon indicating copy to clipboard operation
map-machine copied to clipboard

Data download does not work

Open mfbehrens opened this issue 2 years ago • 3 comments

When I try to run it, it says: "Cannot download data."

Maybe there has been an update in urllib3.

Changing osm/osm_getter.py lin 74 from result = pool_manager.request("GET", address, parameters) to result = pool_manager.request("GET", address, fields=parameters) fixed it for me

mfbehrens avatar Jun 08 '23 20:06 mfbehrens

urllib3 2.0 creates all sort of breakage, some distros like Alpine Linux have chosen to revert. Thanks for the resolution!

fazalmajid avatar Jul 08 '23 17:07 fazalmajid

Oh, I see, there is new syntax in urllib3 version 2 for request() function and I have urllib3>=1.25.6 instead of urllib3~=1.25.6 in requirements.txt file. I will fix that (probably not upgrading to version 2 because of @fazalmajid comment).

@mfbehrens99 Could you please create a pull request, or send me a patch, or at least provide your name/email so that I can apply the patch in your name?

enzet avatar Jul 09 '23 14:07 enzet

@enzet , would it be possible to carry on with this fix? I've just had the same issue. I see there is a PR handling this in #157. With that fix applied, everything seems to work fine.

eliandoran avatar Apr 20 '24 08:04 eliandoran

Thanks everyone for participating. I'm very sorry it took me so long to merge the PR for this issue (#157). I hope it's resolved now.

enzet avatar Nov 18 '25 12:11 enzet