EnyimMemcached icon indicating copy to clipboard operation
EnyimMemcached copied to clipboard

Published 20 hours ago • verified publisher icon enyim

EnyimMemcached with touch support

Open mahirsertkaya opened this issue 9 years ago • 4 comments

Touch support required for extending items' TTL value

mahirsertkaya avatar Jan 06 '16 07:01 mahirsertkaya

Hi, I am using this great library for many years, thanks to you.

I needed an touch operation lately.

In Touch&Gat implementation checkin (enyim committed on Mar 29, 2011), you implemented this method but somehow it is not available in master any more because is no Membase/MembaseClient.cs file.

I hope if it is also works for you, check this commit out please

mahirsertkaya avatar Jan 06 '16 07:01 mahirsertkaya

Hi, It looks really cool and it would be amazing if this commit is merged to master :)

Regards,

javimaravillas avatar Jan 27 '16 07:01 javimaravillas

Hi,

Apologies for getting to this PR so late. On first sight this looks OK, but before merging it, can you please fix the following minor issues:

  • use the same formatting as the rest of the code-base (tab indented, all other C# styles must be default Visual Studio styles)
  • provide tests for the operations
  • do not commit the packages folder
  • do not upgrade packages, unless it's absolutely neccessary

Thanks!

enyim avatar Jan 27 '16 20:01 enyim

Hi i will consider and fix these issues asap

mahirsertkaya avatar Feb 12 '16 17:02 mahirsertkaya