expose icon indicating copy to clipboard operation
expose copied to clipboard

Performance improvement

Open applibs opened this issue 7 years ago • 2 comments

Please change setFilterData($data) to: $filter = new \Expose\Filter(); foreach ($data as $index => $config) { if (is_object($config)) { $config = get_object_vars($config); } $filter->load($config); $this->addFilter($filter); } Thank you.

applibs avatar Dec 14 '16 14:12 applibs

because $index is not used, it can be further simplified:

   /**
     * Set the current filter data
     *
     * @param array $data Filter data
     */
    public function setFilterData($data)
    {
        $filter = new \Expose\Filter();
        foreach ($data as $config) {
            if (is_object($config)) {
                $config = get_object_vars($config);
            }
            $filter->load($config);
            $this->addFilter($filter);
        }
    }

change can be made in FilterCollection.php

swen100 avatar Jan 13 '17 13:01 swen100

Yes , sure. Thx.

applibs avatar Jan 13 '17 13:01 applibs