envoyproxy
Add CertProvider to hot reload TLS certs for gRPC service
This implements a goruntime instance to watch for on disk changes of gRPC certificates.
Certificates will be reloaded in case of change and the gRPC service will always fetch the latest one via GetCertificate on new connections instead of the static Certificates slice.
Can you add documentation for this change and optimally some kind of test?
I've added documentation for it. Regarding tests I'm a bit unsure. I could write tests for CertProvider which would need to heavily mock the goruntime parts or tests them as well (which I don't think is desired). What would you suggest to write tests for here?
What would you suggest to write tests for here?
In a perfect world some kind of integration test.
What would you suggest to write tests for here?
In a perfect world some kind of integration test.
Done. Hope this looks like something you would expect.