ratelimit icon indicating copy to clipboard operation
ratelimit copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

Support Tracing

Open ethernoy opened this issue 3 years ago • 7 comments
trafficstars

I am experiencing some difficulty when troubleshooting a slow ratelimit installation. I believe adding tracing of any format (preferrably zipkin or openTelemetry) to the ratelimit service can be of great help.

Happy to submit a PR if this is ok.

ethernoy avatar Apr 12 '22 04:04 ethernoy

Sure, though I would go straight to Open Telemetry.

mattklein123 avatar Apr 12 '22 13:04 mattklein123

Sure, though I would go straight to Open Telemetry.

Great, then let me work on it

ethernoy avatar Apr 13 '22 03:04 ethernoy

Sure, though I would go straight to Open Telemetry.

@mattklein123 Have a question in mind: if we are going to send out OTEL span when calling memcached and redis, it probably needs the caller to pass the parent traceId in gRPC request body, which isn't around for now according to the proto file in envoyproxy project:

https://github.com/envoyproxy/envoy/blob/main/api/envoy/service/ratelimit/v2/rls.proto https://github.com/envoyproxy/envoy/blob/main/api/envoy/service/ratelimit/v3/rls.proto

Should we consider to add such data in the ratelimit request protocol? Also we will need to add the implementation in envoyproxy in order to produce a full trace.

ethernoy avatar Apr 19 '22 14:04 ethernoy

Yeah we can add this to the API for sure.

mattklein123 avatar Apr 19 '22 16:04 mattklein123

Yeah we can add this to the API for sure.

Nice, then let me finish the implementation from ratelimit side first

ethernoy avatar Apr 19 '22 16:04 ethernoy

fixed by https://github.com/envoyproxy/ratelimit/pull/332？

zirain avatar Apr 18 '23 02:04 zirain

Can we close this if it was taken care of by https://github.com/envoyproxy/ratelimit/pull/332 ?

ChezCrawford avatar Oct 13 '23 17:10 ChezCrawford