nighthawk

nighthawk copied to clipboard

Publish arm64 docker images

1

*Title*: Publish arm64 docker images *Description*: Envoyproxy currently publisjhes multi-arch images with amd64 and arm64. It would be great if nighthawk did, as well. [optional *Relevant Links*:] >Any extra documentation...

howardjohn

With https://github.com/envoyproxy/nighthawk/pull/885, GetMetricByName is now deprecated in favor of GetMetricByNameWithReportingPeriod. We should give users of the plugin system time to migrate over and begin process to eventually remove the old...

tomjzzhang

Configuring nighthawk-client not to reusing session makes results 10 times worse (and utilization of w CPU/RAM assign to nighthawk server is very low less than 10% )

4

*Title*: Results for nighthawk client configured not to reuse the session are 10 times less (and utilization of w CPU/RAM assign to nighthawk server is very low, less than 10%...

lzielezinska

Nighthawk doesn't correctly drain the connection pool

3

The pool termination code is [here](https://github.com/envoyproxy/nighthawk/blob/ed015dd6ceb77f998b34f124613c0fcd33d540e8/source/client/benchmark_client_impl.cc#L110-L131). While the code does register an idle callback, that callback only gets called if the pool is draining. Nighthawk doesn't seem to trigger pool...

mum4k

After https://github.com/envoyproxy/nighthawk/pull/855/ is pushed through, these two filters now have their own configuration for starting up the filters, without any internal references to ResponseOptions.proto. However, the header override api still...

dubious90

add dedicated counters for a few common 4xx and 5xx codes

3

Can we afford to add 5 or 15 counters to help troubleshoot these specific HTTP outcomes? These would be **in addition** to today's catch-all `http_4xx` and `http_5xx` counters. Usually if...

eric846

Support gRPC

9

Add the capability to load-test the gRPC protocol.

oschaaf

With PR #827 out integration test coverage is at `74.2%`. We should organize a fixit effort to push it at least above `80%`, ideally to the `90%` range.

mum4k

Improve error message when terminating due to a predicate

1

Nighthawk will sometimes terminate some of its worker threads early, before the specified --duration has elapsed. It reports the error: `[E] Exiting due to failing termination predicate` This error message...

mum4k

Nighthawk's [check_format.py](https://github.com/envoyproxy/nighthawk/blob/d3d6d3a60ce02ea9cf0466f16534f89fdd6a2c58/tools/check_format.sh#L1) is reusing [the Envoy version](https://github.com/envoyproxy/envoy/blob/d3bd9bbef64abbf1c02fe91231eac8841901131d/tools/code_format/check_format.py#L1). Envoy includes a set of Envoy specific checks that cannot be applied in the Nighthawk codebase without code changes upstream. As an example,...

mum4k