java-control-plane icon indicating copy to clipboard operation
java-control-plane copied to clipboard

Watch Created with Empty Resource Names

Open minwoox opened this issue 1 year ago • 0 comments
trafficstars

According to the Envoy xDS protocol documentation:

If the list of resource names becomes empty, that means the client is no longer interested in any resources of the specified type.

However, the DiscoveryRequestStreamObserver currently creates a new watch even when the resource names list becomes empty, which violates the spec. https://github.com/envoyproxy/java-control-plane/blob/main/server/src/main/java/io/envoyproxy/controlplane/server/DiscoveryRequestStreamObserver.java#L80-L94

I think we can just cancel the previous watch and not create another one in this case. Please let me know if this makes sense, and I’ll be happy to submit a PR.

minwoox avatar Sep 23 '24 10:09 minwoox