java-control-plane
java-control-plane copied to clipboard
bug fix to requested resource does not exist handling
Bug fix to requested resource does not exist handling. We need to keep watch active for when resource is finally created so we can notify client.
This is to match the xDS spec for how to handle the "resource does not exist" scenario.
Open issue: https://github.com/envoyproxy/java-control-plane/issues/219
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.15%. Comparing base (
eaca1a4) to head (272d28f). Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #373 +/- ##
============================================
- Coverage 86.16% 86.15% -0.02%
Complexity 361 361
============================================
Files 42 42
Lines 1178 1177 -1
Branches 97 97
============================================
- Hits 1015 1014 -1
Misses 116 116
Partials 47 47
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@staticfinalzero looks like you haven't signed off your commit and that causes CI to be red. Any chance you can fix?
Sorry about that, I've amended the commit and signed off.