java-control-plane icon indicating copy to clipboard operation
java-control-plane copied to clipboard

cache: unsubscribe removed resources on reconnects

Open sschepens opened this issue 1 year ago • 1 comments
trafficstars

When reconnections occur, envoy sends a new request subscribing to all the resources it currently had. If a resource has just been removed, we fail to notify Envoy the the resource has been removed.

This happens because on the very first stream request, we dont have any trackedResources, we should instead also check pendingResources.

sschepens avatar Jan 24 '24 15:01 sschepens

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4577722) 86.16% compared to head (154e449) 86.24%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #320      +/-   ##
============================================
+ Coverage     86.16%   86.24%   +0.08%     
- Complexity      361      363       +2     
============================================
  Files            42       42              
  Lines          1178     1178              
  Branches         97       97              
============================================
+ Hits           1015     1016       +1     
+ Misses          116      115       -1     
  Partials         47       47              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 24 '24 15:01 codecov-commenter