java-control-plane icon indicating copy to clipboard operation
java-control-plane copied to clipboard

Add control plane identifier in DiscoveryServer responses

Open Ferdudas97 opened this issue 3 years ago • 2 comments
trafficstars

The purpose of this task was to increase observability. With these changes, we are able to tell from which control-plane envoy gets responses.

Ferdudas97 avatar Jun 29 '22 13:06 Ferdudas97

Codecov Report

Merging #245 (9860983) into main (90a3ccd) will increase coverage by 0.09%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #245      +/-   ##
============================================
+ Coverage     86.24%   86.33%   +0.09%     
  Complexity      351      351              
============================================
  Files            41       41              
  Lines          1141     1149       +8     
  Branches         93       93              
============================================
+ Hits            984      992       +8     
  Misses          112      112              
  Partials         45       45              
Impacted Files Coverage Δ
...nvoyproxy/controlplane/server/DiscoveryServer.java 97.05% <100.00%> (+0.18%) :arrow_up:
...oyproxy/controlplane/server/V3DiscoveryServer.java 94.11% <100.00%> (+0.56%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 15 '22 09:07 codecov-commenter

kindly ping @rulex123 @nezdolik

liangyuanpeng avatar Jun 24 '23 06:06 liangyuanpeng