java-control-plane icon indicating copy to clipboard operation
java-control-plane copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

Implement Delta xDS

Open YashMathur opened this issue 5 years ago • 5 comments
trafficstars

Are there any plans to add an implementation of the delta xDS? I see that there's an open PR in go-control-plane to implement the delta xDS.

YashMathur avatar Oct 05 '20 20:10 YashMathur

@sschepens I believe you have a fork of this don't you?

alecholmez avatar Oct 09 '20 19:10 alecholmez

Yup, i have this implemented on a fork of mine. Couple of things:

  • Not based on current changes
  • Breakes API compatibility (though i think it best)
  • Has no tests, but has been running in production for months now

I wont have time to add the correct tests to allow it to be merged, but could probably update it with recent changes in the repo and submit a PR so that someone can continue from that.

sschepens avatar Oct 20 '20 21:10 sschepens

I don't have a horse in this race but IMO delta is a big enough change that a breaking API (or new API) would be warranted in order to support things such as on demand xDS.

snowp avatar Oct 20 '20 21:10 snowp

Yeah I think so too, the change I made to the API is not so great, it just basically forces clients to provide each resource with it's corresponding version when building a snapshot. Will be posting a PR maybe today so that some can get a look at it and maybe someone wants to take it over.

sschepens avatar Oct 22 '20 12:10 sschepens

@YashMathur do you have time to pick up the work done by @sschepens, add tests / docs and make the PR review ready?

slonka avatar Dec 11 '20 10:12 slonka