go-control-plane icon indicating copy to clipboard operation
go-control-plane copied to clipboard

Include a sample Rate-Limit config xDS server

Open renuka-fernando opened this issue 2 years ago • 1 comments

I am working on https://github.com/envoyproxy/ratelimit/issues/201 which is a feature for updating Rate Limit Service configurations dynamically through an xDS server.

As per https://github.com/envoyproxy/ratelimit/issues/201 I thought of adding the server-related implementation within the go-control-plane repository. Then we could re-use most of the readily available functions here. Hence, I created this git issue to discuss how we can achieve this.

Please share your thoughts on this.

renuka-fernando avatar Oct 03 '22 11:10 renuka-fernando

Hi @renuka-fernando this would be awesome!

I'd actually like to have the rate limit service become a first class citizen of this repo since it's needed for control-plane functionality :)

alecholmez avatar Oct 03 '22 14:10 alecholmez

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 17 '22 20:11 github-actions[bot]

hi @alecholmez,

Is it possible to add the "no stalebot" label?

renuka-fernando avatar Nov 18 '22 05:11 renuka-fernando

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 18 '22 12:12 github-actions[bot]

hi @renuka-fernando can you kindly add this to java-control-plane too, Please.. It will be super helpful.

kkcmadhu avatar Dec 21 '22 06:12 kkcmadhu

hi @renuka-fernando can you kindly add this to java-control-plane too, Please.. It will be super helpful.

sure, I will. Once @alecholmez confirms the changes on go control plane, I will have a look at the java control plane as well.

renuka-fernando avatar Dec 21 '22 06:12 renuka-fernando

kindly, have this included in java control plane too, i am eagerly awating to try it out.

kkcmadhu avatar Jan 27 '23 16:01 kkcmadhu

Hi @alecholmez,

Missed one more thing, we have to have a way to generate pb files. As we discussed here https://github.com/envoyproxy/go-control-plane/pull/598#discussion_r1008130688

So could you reopen this again to track it? Source proto files: https://github.com/envoyproxy/ratelimit/pull/371

renuka-fernando avatar Jan 31 '23 04:01 renuka-fernando

@renuka-fernando okay great! Thanks for following up with that.

alecholmez avatar Jan 31 '23 17:01 alecholmez