go-control-plane icon indicating copy to clipboard operation
go-control-plane copied to clipboard

[#583][Delta] Ensure resources are properly sent again if envoy unsubscribes then subscribes again to a resource

Open valerian-roche opened this issue 2 years ago • 3 comments

This PR is part of the fix for https://github.com/envoyproxy/go-control-plane/issues/583 related to resources being unsubscribed from then subscribed to again This one applies to both simple and linear cache when using the delta protocol. Actionable cases would likely only impact delta-ADS as EDS outside of ADS does not share streams and will therefore usually not have multiple resources this way

The logger issue is related to sotw-ADS which is part of a followup PR This PR is built on top of https://github.com/envoyproxy/go-control-plane/pull/584 as the sotw part will be heavily relying on it

valerian-roche avatar Aug 25 '22 13:08 valerian-roche

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Sep 24 '22 16:09 github-actions[bot]

is this work still active?

haoruolei avatar Feb 06 '23 20:02 haoruolei

This work builds on #584, which itself now depends on rolling back #615. Sadly graphite and branch stacking cannot be done across forks Alec has had few cycles recently to review, but when he becomes available I hope to have those move ahead

valerian-roche avatar Mar 14 '23 19:03 valerian-roche