go-control-plane icon indicating copy to clipboard operation
go-control-plane copied to clipboard

sotw: Ordered ADS mode

Open alecholmez opened this issue 2 years ago • 4 comments

introduce optional resource ordering for guaranteed eventual consistency in ADS mode. closes #526

alecholmez avatar Mar 07 '22 20:03 alecholmez

This PR branches off the work found here: https://github.com/envoyproxy/go-control-plane/pull/461 and brings it up to speed with the current state of go-control-plane. Credit to the original algorithm author @fxposter (would be great if he could review)/ We've found quite a few resource ordering issues in upstream xDS conformance test suites and this will hopefully provide a remedy to some of those problems.

I tried to introduce the change in a non intrusive way, if no opts are provided to the server everything will execute as before. If the new opt sotw.WithOrderedADS() is passed to a server, the resources will be in guaranteed ordering as in the prior art PR. This provides guaranteed eventual consistency which we did not have in the previous implementation but gives up some of the pressure relief from immediate response sending.

alecholmez avatar Mar 07 '22 20:03 alecholmez

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar May 02 '22 04:05 github-actions[bot]

Haven’t had much bandwidth to work this recently will get back to it soon.

alecholmez avatar May 02 '22 13:05 alecholmez

any progress on this?

marcosrmendezthd avatar Jul 07 '22 13:07 marcosrmendezthd

Need to fix the integration tests and then this should be ready for a rereview

alecholmez avatar Jan 27 '23 21:01 alecholmez

Hi do we have updates on this PR?

haoruolei avatar Feb 15 '23 00:02 haoruolei

This PR is ready! Hopefully we can merge soon

alecholmez avatar Mar 21 '23 15:03 alecholmez

@valerian-roche tagging you on a review for this one

alecholmez avatar Mar 21 '23 15:03 alecholmez

Hi is there any update on this?

haoruolei avatar Apr 27 '23 17:04 haoruolei

@alecholmez guessing a similar ordering enforcement will be required for delta + ads as well ?

arkodg avatar May 05 '23 16:05 arkodg

@arkodg Yup we'll need to port this over

alecholmez avatar May 15 '23 14:05 alecholmez