remove dependency on github.com/census-instrumentation/opencensus-proto

[codyoss]

Open Census is now deprecated and the project mentioned archive has been archived for over a year. I have seen some dependency issues popping up in the go/proto/grpc space and have traced it back to this dependency having a really old refs on google.golang.org/genproto in this repo. Is there a plan to remove this dependency from the tree? As another issue pointed out, which I have linked below, this can also pose a security risk to depend upon projects that are not getting updated.

Previous issue that was autoclosed: #952

[kyessenov]

We cannot remove it until OpenCensus is deleted in Envoy core extensions. How does this cause issue for genproto? It's just another proto?

[codyoss]

@kyessenov it is related to the issue linked above. TLDR is we did a module split to limit the dependencies pulled into some projects that depend on genproto. But this can cause an ambiguous import if you have a really old ref to genproto these days -- such as demonstrated in this open census project.

We cannot remove it until OpenCensus is deleted in Envoy core extensions.

Is this planned work, and is there an issue we can follow?

[kyessenov]

https://github.com/envoyproxy/envoy/issues/9958 is the issue tracking the replacement.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[codyoss]

can we add no stalebot to this. This remains a problem for for our Cloud SDK.

[ggreenway]

This should be fixed in Envoy in https://github.com/envoyproxy/envoy/commit/e456b9ba7683a09cea7a7f2af6d3a5a5c2ac10a6

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[codyoss]

Again can we add a nostale to this issue as it is still active.

[valerian-roche]

Hey @codyoss From what I can see, the dependency on opencensus got removed through this commit, which is part of v0.13.4/envoy/v1.32.3 releases. Can you confirm if those releases address the concern?

[Integralist]

👋🏻

In my project I'm seeing:

        google.golang.org/grpc/xds/internal/xdsclient/xdsresource imports
        github.com/envoyproxy/go-control-plane/envoy/service/discovery/v3: ambiguous import: found package github.com/envoyproxy/go-control-plane/envoy/service/discovery/v3 in multiple modules:
        github.com/envoyproxy/go-control-plane v0.13.1 (/Users/integralist/go/pkg/mod/github.com/envoyproxy/[email protected]/envoy/service/discovery/v3)
        github.com/envoyproxy/go-control-plane/envoy v1.32.3 (/Users/integralist/go/pkg/mod/github.com/envoyproxy/go-control-plane/[email protected]/service/discovery/v3)

I'm trying to track down where this might be discussed resolved, so if this isn't that place then please let me know and I'll move on 🙂

I'm not sure what the resolution needs to be outside of using a replace directive in my go.mod but it's tricky to know which version of the go-control-planeto use as one version0.13.1is much older than1.32.3` so breakages are possible)

Thanks.

EDIT: looks like this is tracked here? https://github.com/googleapis/google-cloud-go/issues/11344

[valerian-roche]

As far as I can see 0.13.4 does not depend on opencensus-proto anymore, hence closing this issue. Please reopen it if still applicable