gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: add query parameter match support in ratelimit

Open slayer321 opened this issue 2 months ago • 6 comments

What type of PR is this?

feat: add query parameter match support in ratelimit

What this PR does / why we need it: It adds the query parameter support for ratelimit Which issue(s) this PR fixes:

Fixes #6790

Release Notes: Yes/No

slayer321 avatar Oct 24 '25 12:10 slayer321

Codecov Report

:x: Patch coverage is 67.64706% with 22 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 72.36%. Comparing base (26a7734) to head (95a04bb).

Files with missing lines Patch % Lines
internal/gatewayapi/backendtrafficpolicy.go 39.39% 19 Missing and 1 partial :warning:
internal/xds/translator/ratelimit.go 90.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7330      +/-   ##
==========================================
- Coverage   72.38%   72.36%   -0.03%     
==========================================
  Files         234      234              
  Lines       34566    34631      +65     
==========================================
+ Hits        25020    25060      +40     
- Misses       7757     7779      +22     
- Partials     1789     1792       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 24 '25 12:10 codecov[bot]

Hey @arkodg, I noticed there are quite a few merge conflicts in my PR. I tried resolving them, but it’s getting a bit messy. Would it be okay if I open a new PR with my changes rebased on top of main?

slayer321 avatar Oct 31 '25 11:10 slayer321

Hey @arkodg , I see there are some new review comment . I had this query https://github.com/envoyproxy/gateway/pull/7330#issuecomment-3472581709

can i do this ? .. Create a new PR and close this one. Will incorporate all the changes that you have mentioned in the new PR.

slayer321 avatar Nov 24 '25 14:11 slayer321

Hey can you please use this PR to keep all the conversations in one place and to reduce reviewer burden ( to review incremental diff vs entire diff )

arkodg avatar Nov 24 '25 14:11 arkodg

@slayer321 can you fix the conflict and reslove arko's comment?

zirain avatar Dec 10 '25 04:12 zirain

Hey @zirain , I have resolve the merge conflicts and also addresed arko's comment.

slayer321 avatar Dec 11 '25 05:12 slayer321