gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: Make xDS Service name configurable via ENVOY_GATEWAY_SERVICE_NAME

Open ADITYATIWARI342005 opened this issue 3 months ago • 3 comments

What type of PR is this?

feat: New feature - adds configurability for Envoy Gateway service name

What this PR does / why we need it:

This PR makes the Envoy Gateway service name configurable through the ENVOY_GATEWAY_SERVICE_NAME environment variable, solving the issue where multiple gateway instances couldn't run in the same namespace due to hardcoded service name.

Usage:

env:
- name: ENVOY_GATEWAY_SERVICE_NAME
  value: "my-custom-gateway"

Which issue(s) this PR fixes:

Fixes #6997 Closes #6997

Release Notes: Yes

ADITYATIWARI342005 avatar Sep 24 '25 19:09 ADITYATIWARI342005

Codecov Report

:x: Patch coverage is 93.22034% with 12 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.17%. Comparing base (a478b74) to head (a7b05fb). :warning: Report is 236 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/bootstrap/bootstrap.go 94.83% 8 Missing :warning:
internal/cmd/certgen.go 0.00% 1 Missing :warning:
internal/infrastructure/host/infra.go 0.00% 1 Missing :warning:
internal/infrastructure/host/proxy_infra.go 0.00% 1 Missing :warning:
internal/xds/runner/runner.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7049      +/-   ##
==========================================
+ Coverage   71.07%   71.17%   +0.09%     
==========================================
  Files         228      228              
  Lines       40691    40806     +115     
==========================================
+ Hits        28922    29044     +122     
+ Misses      10072    10070       -2     
+ Partials     1697     1692       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 01 '25 20:10 codecov[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Nov 12 '25 00:11 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Dec 12 '25 04:12 github-actions[bot]