gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Observability Design and Implementation of EG

Open Xunzhuo opened this issue 3 years ago • 12 comments

Description:

This issue tracks the Observability designs and implementations of EG.

EG Observability Design should be two main parts and such subtasks:

  • The Control Plane (CP): Design and Implement the CP Observability of EG (https://github.com/envoyproxy/gateway/issues/700).

    • [ ] Metrics generated by Envoy Gateway
    • [ ] Logging generated by Envoy Gateway
    • [ ] Tracing generated by Envoy Gateway
  • The Data Plane (DP): Design and Implement the DP Observability of EG (https://github.com/envoyproxy/gateway/issues/699).

    • [x] Access Logging generated by EnvoyProxy
    • [x] Tracing generated by EnvoyProxy
    • [x] Metrics generated by EnvoyProxy

Welcome to comment your ideas related to Observability here.

Xunzhuo avatar Nov 05 '22 09:11 Xunzhuo

@Xunzhuo unless you're actively working on this issue, can you unassign yourself and add the help-wanted label?

danehans avatar Jan 11 '23 16:01 danehans

@danehans I will still assign myself to this issue, this issue records the process of implementing EG observability, I will schedule to work on this in the next releases.

But I free some sub tasks of this epic, hope that someone can work on them, or I can spare some time on them.

Xunzhuo avatar Jan 11 '23 16:01 Xunzhuo

@zirain since you're interested as well as fairly knowledgable in this area, assigning this issue to you as well, hoping you and @Xunzhuo can tackle this together in the next release 🚀

arkodg avatar Mar 23 '23 01:03 arkodg

xref: https://github.com/istio/istio/pull/44094 case about grpc stats

zirain avatar Mar 29 '23 00:03 zirain

We should also include observability for filters here even if the work is done upstream.

jcchavezs avatar May 03 '23 11:05 jcchavezs

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Jun 03 '23 04:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Jul 14 '23 16:07 github-actions[bot]

@shawnh2 will work on control plane part.

zirain avatar Apr 23 '24 02:04 zirain

how is the support for openetelemtry traces, logs, metrics? I can see it is in design phase on envoyproxies page. Is there anything more being done?

kevintatou avatar Apr 26 '24 08:04 kevintatou

how is the support for openetelemtry traces, logs, metrics? I can see it is in design phase on envoyproxies page. Is there anything more being done?

it's completed, you can try it.

zirain avatar Apr 26 '24 09:04 zirain

how is the support for openetelemtry traces, logs, metrics? I can see it is in design phase on envoyproxies page. Is there anything more being done?

it's completed, you can try it.

Is there any example on how to do it in otel with my own collector? I cant seem to find it 🤔

kevintatou avatar Apr 26 '24 10:04 kevintatou

I cannot recall if there's a user face doc, but you check the e2e test https://github.com/envoyproxy/gateway/tree/main/test/e2e

zirain avatar Apr 26 '24 11:04 zirain

The Metrics of EG CP will be discussed and resolved in #2092

shawnh2 avatar Apr 29 '24 06:04 shawnh2

@shawnh2 so metrics is not implemented yet? Do you know if tracing is?

kevintatou avatar Apr 29 '24 08:04 kevintatou

@shawnh2 so metrics is not implemented yet? Do you know if tracing is?

hi @kevintatou, the metrics/tracing/logging for envoy gateway control plane is not implemented yet. But the data plane does (all of them), you can browse the doc to find more.

shawnh2 avatar Apr 30 '24 02:04 shawnh2

Let us close this, and track cp metrics progress in https://github.com/envoyproxy/gateway/issues/2092.

Xunzhuo avatar Apr 30 '24 03:04 Xunzhuo

@zirain any plans on doing otel over http? writing a grpc service just to get the access log looks like overkill to me...

pkit avatar May 16 '24 22:05 pkit

@zirain any plans on doing otel over http? writing a grpc service just to get the access log looks like overkill to me...

does grpc has better perfmance?

zirain avatar May 16 '24 23:05 zirain

It does. Usually.

pkit avatar May 17 '24 00:05 pkit