gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: extend load resources to support multiple gatewayclasses and envoyproxies

Open shawnh2 opened this issue 7 months ago • 4 comments

What type of PR is this?

What this PR does / why we need it:

Change the load function in gatewayapi/resources to support multiple gatewayclasses and envoyproxies:

  • For file provider, it can prevent resources from being lumped together (#5858)
  • For egctl x translate, allow it to process multiple gatewayclasses tranlaste and even merge gateways translate (#3937)

Which issue(s) this PR fixes:

Fixes #3207, close #3960

Release Notes: Yes

shawnh2 avatar May 07 '25 23:05 shawnh2

is this for v1.4.0 @shawnh2 ?

arkodg avatar May 07 '25 23:05 arkodg

is this for v1.4.0 @shawnh2 ?

yeah

shawnh2 avatar May 07 '25 23:05 shawnh2

Codecov Report

Attention: Patch coverage is 79.85075% with 27 lines in your changes missing coverage. Please review.

Project coverage is 65.93%. Comparing base (da98c66) to head (8750b75). Report is 246 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/file/store.go 29.62% 15 Missing and 4 partials :warning:
internal/cmd/egctl/simple_controller.go 68.75% 3 Missing and 2 partials :warning:
internal/cmd/egctl/translate.go 78.57% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5950      +/-   ##
==========================================
+ Coverage   65.82%   65.93%   +0.10%     
==========================================
  Files         217      218       +1     
  Lines       36016    36091      +75     
==========================================
+ Hits        23709    23796      +87     
+ Misses      10832    10812      -20     
- Partials     1475     1483       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 07 '25 23:05 codecov[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 12 '25 04:06 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jul 12 '25 08:07 github-actions[bot]

Can we land this in v1.5? I'm working on enable standalone for all e2e tests recently, and this will block me.

shawnh2 avatar Aug 02 '25 03:08 shawnh2

too much of conflicts, will reopen a PR for this

shawnh2 avatar Aug 15 '25 11:08 shawnh2