gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: combine xds-translator and xds-server runners

Open arkodg opened this issue 1 year ago • 3 comments

  • The combined runner is called xds
  • This should eliminate one layer of caching resulting in mem savings

Fixes: https://github.com/envoyproxy/gateway/issues/3980

arkodg avatar Sep 24 '24 17:09 arkodg

this is a breaking change

  • the log components - xdc-translator and xds-server have been removed and a new log component xds has been added
  • this also affects change in control plane metrics labels

arkodg avatar Sep 24 '24 18:09 arkodg

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 65.55%. Comparing base (bd966b8) to head (bb3137a). Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/runner/runner.go 0.00% 52 Missing :warning:
internal/cmd/server.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4326      +/-   ##
==========================================
- Coverage   65.74%   65.55%   -0.19%     
==========================================
  Files         197      196       -1     
  Lines       23767    23719      -48     
==========================================
- Hits        15626    15550      -76     
- Misses       7020     7059      +39     
+ Partials     1121     1110      -11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 24 '24 19:09 codecov[bot]

looks like the mem usage increased, that looks odd cc @shawnh2

arkodg avatar Sep 25 '24 00:09 arkodg