gateway icon indicating copy to clipboard operation
gateway copied to clipboard
verified publisher icon envoyproxy

feat: finalize envoyproxy for gatewayclass

Open cnvergence opened this issue 1 year ago • 8 comments

What type of PR is this?

What this PR does / why we need it: Restore work on EnvoyProxy finalizers, only for those referenced by the GatewayClass. We have ran into issues with Merged Gateways deployments. https://github.com/envoyproxy/gateway/pull/3533#issuecomment-2149533649

Which issue(s) this PR fixes:

Fixes https://github.com/envoyproxy/gateway/issues/865

cnvergence avatar Jul 22 '24 14:07 cnvergence

Codecov Report

Attention: Patch coverage is 68.65672% with 21 lines in your changes missing coverage. Please review.

Project coverage is 67.92%. Comparing base (71519af) to head (dc0f602). Report is 994 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 68.65% 12 Missing and 9 partials :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3930      +/-   ##
==========================================
- Coverage   67.92%   67.92%   -0.01%     
==========================================
  Files         187      187              
  Lines       23018    23057      +39     
==========================================
+ Hits        15636    15661      +25     
- Misses       6266     6273       +7     
- Partials     1116     1123       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 23 '24 14:07 codecov[bot]

HI @cnvergence thanks for picking this up. This PR overall looks good; I just have a few comments.

zhaohuabing avatar Jul 25 '24 12:07 zhaohuabing

/retest

cnvergence avatar Jul 25 '24 12:07 cnvergence

/retest

cnvergence avatar Jul 30 '24 12:07 cnvergence

/retest

cnvergence avatar Aug 02 '24 13:08 cnvergence

/retest

shawnh2 avatar Aug 02 '24 14:08 shawnh2

/retest

cnvergence avatar Aug 19 '24 14:08 cnvergence

@shawnh2 @zhaohuabing had you chance to take a look again?

cnvergence avatar Aug 22 '24 14:08 cnvergence

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 03 '24 16:10 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Nov 03 '24 00:11 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Dec 08 '24 16:12 github-actions[bot]

closing this PR since its become inactive, feel free to reopen if you're still working on it

arkodg avatar May 23 '25 02:05 arkodg