gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat(policy): Add CTP support for TCP/TLS listeners

Open aoledk opened this issue 9 months ago • 5 comments

What this PR does / why we need it:

Enable user to attach ClientTrafficPolicy ^1 to TCP/TLS listeners, available fields are:

  • tcpKeepalive
  • connection
  • enableProxyProtocol
  • tls
  • ~~timeout~~ (new field will be needed to specify tcp idle timeout in clientTimeout ^2, raised in other issue #3343)

Which issue(s) this PR fixes:

Fixes #3163

aoledk avatar May 07 '24 11:05 aoledk

/retest

aoledk avatar May 11 '24 06:05 aoledk

/retest

aoledk avatar May 15 '24 06:05 aoledk

/retest

aoledk avatar May 16 '24 05:05 aoledk

/retest

aoledk avatar May 17 '24 02:05 aoledk

Codecov Report

Attention: Patch coverage is 80.45977% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 67.43%. Comparing base (8206e11) to head (926a50b).

Files Patch % Lines
internal/gatewayapi/clienttrafficpolicy.go 77.92% 14 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3337      +/-   ##
==========================================
+ Coverage   67.41%   67.43%   +0.02%     
==========================================
  Files         166      166              
  Lines       19186    19214      +28     
==========================================
+ Hits        12934    12957      +23     
- Misses       5322     5325       +3     
- Partials      930      932       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '24 07:05 codecov[bot]

@arkodg Do you think whether it's necessary to split this big PR to multiple small PRs for easier review ? Each small PR for single field in CTP.

aoledk avatar May 22 '24 08:05 aoledk

@arkodg Do you think whether it's necessary to split this big PR to multiple small PRs for easier review ? Each small PR for single field in CTP.

sorry for the delay in reviewing this one, on it !

arkodg avatar May 22 '24 20:05 arkodg