gateway
gateway copied to clipboard
envoyproxy
feat: support access log formatters
What this PR does / why we need it:
Enable user to configure access log formatter ^1.
Which issue(s) this PR fixes:
Fixes #3279
this reminder should take a look if open telemetry access logger support this formatter.
this reminder should take a look if open telemetry access logger support this formatter.
I've checked Envoy docs about access log, it's not an option to set formatter for open telemetry access log ^1.
this reminder should take a look if open telemetry access logger support this formatter.
I've checked Envoy docs about access log, it's not an option to set formatter for open telemetry access log 1.
Footnotes
- https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/access_loggers/open_telemetry/v3/logs_service.proto#extension-envoy-access-loggers-open-telemetry ↩
but CEL METADATA should work on it.
but
CELMETADATAshould work on it.
I need to validate whether CEL or METADATA works with open telemetry access log under specific envoy configs.
I'll updated when it's done.
but
CELMETADATAshould work on it.I need to validate whether
CELorMETADATAworks with open telemetry access log under specific envoy configs.I'll updated when it's done.
it's not blocker for this PR.
When CEL or METADATA or REQ_WITHOUT_QUERY is configured in open telemetry access log, Envoy will panic ^1 with error Not supported field in StreamInfo: CEL or Not supported field in StreamInfo: METADATA or Not supported field in StreamInfo: REQ_WITHOUT_QUERY.
When
CELorMETADATAorREQ_WITHOUT_QUERYis configured in open telemetry access log, Envoy will panic 1 with errorNot supported field in StreamInfo: CELorNot supported field in StreamInfo: METADATAorNot supported field in StreamInfo: REQ_WITHOUT_QUERY.Footnotes
- https://github.com/envoyproxy/envoy/blob/2092d65bd4d476be8235ea541e5d25c096b513e6/source/common/formatter/stream_info_formatter.h#L277 ↩
Thinks for trying this, envoy should support this.
