gateway icon indicating copy to clipboard operation
gateway copied to clipboard
verified publisher icon envoyproxy

Enable `loopvar` feature of go for EG

Open shawnh2 opened this issue 1 year ago • 3 comments 

          This loopvar feature of go 1.22 requires enable env `GOEXPERIMENT=loopvar` (default closed) explicitly. Maybe we could consider enable this feature for other places as well.

Originally posted by @shawnh2 in https://github.com/envoyproxy/gateway/issues/2739#issuecomment-2068969587

shawnh2 avatar Apr 22 '24 09:04 shawnh2

The usage of this feature requires setting go env specificly, for example GOEXPERIMENT=loopvar go test.

shawnh2 avatar Apr 22 '24 09:04 shawnh2

I'm very interested in this issue, please assign it to me.

Awinr avatar Apr 22 '24 10:04 Awinr

the loopvar can be detected by https://golangci-lint.run/usage/linters#copyloopvar

shawnh2 avatar May 20 '24 02:05 shawnh2

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Jun 19 '24 04:06 github-actions[bot]

@shawnh2 is this issue still relevant? I would like to work on this

EraKin575 avatar Jul 21 '24 07:07 EraKin575

@Awinr are you working on this?

EraKin575 avatar Jul 21 '24 07:07 EraKin575

@shawnh2 is this issue still relevant? I would like to work on this

Yes, thinks for taking this issue, assign you.

shawnh2 avatar Jul 21 '24 07:07 shawnh2