gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: add xRoute and xPolicy support for egctl x status

Open shawnh2 opened this issue 1 year ago • 2 comments

What type of PR is this?

What this PR does / why we need it:

  • add support for xRoute and xPolicy input types
  • display Parents and Ancestors for xRoute or xPolicy
  • get rid of all the reflect errors handling, since we can promise all these fields exist

some usage example:

image
  • the kind name in ParentRef has been changed to lower case

Which issue(s) this PR fixes:

follow-up of #2631

shawnh2 avatar Mar 17 '24 12:03 shawnh2

Codecov Report

Attention: Patch coverage is 67.21311% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 66.92%. Comparing base (4c52f10) to head (52f3ede). Report is 4 commits behind head on main.

:exclamation: Current head 52f3ede differs from pull request most recent head 9ca8774. Consider uploading reports for the commit 9ca8774 to get more accurate results

Files Patch % Lines
internal/cmd/egctl/status.go 67.21% 40 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2949      +/-   ##
==========================================
+ Coverage   66.89%   66.92%   +0.03%     
==========================================
  Files         163      163              
  Lines       23453    23347     -106     
==========================================
- Hits        15689    15626      -63     
+ Misses       6838     6822      -16     
+ Partials      926      899      -27     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 17 '24 12:03 codecov[bot]

/retest

shawnh2 avatar Mar 20 '24 03:03 shawnh2