gateway icon indicating copy to clipboard operation
gateway copied to clipboard

chore: use list instead of map for Provider Resources

Open arkodg opened this issue 1 year ago • 3 comments

  • list adds order stability

arkodg avatar Feb 20 '24 01:02 arkodg

/retest

zirain avatar Feb 20 '24 10:02 zirain

LGTM, tests need to be updated

cnvergence avatar Feb 20 '24 10:02 cnvergence

/retest

zhaohuabing avatar Feb 20 '24 13:02 zhaohuabing

@arkodg conflicts need to be resolved.

Xunzhuo avatar Mar 01 '24 06:03 Xunzhuo

Codecov Report

Attention: Patch coverage is 54.00000% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 63.62%. Comparing base (3e70498) to head (fe19fe9).

Files Patch % Lines
internal/provider/kubernetes/controller.go 57.14% 7 Missing and 2 partials :warning:
internal/message/types.go 0.00% 8 Missing :warning:
internal/gatewayapi/resource.go 83.33% 2 Missing and 1 partial :warning:
internal/gatewayapi/runner/runner.go 0.00% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2658      +/-   ##
==========================================
+ Coverage   63.53%   63.62%   +0.09%     
==========================================
  Files         123      123              
  Lines       20169    20173       +4     
==========================================
+ Hits        12814    12835      +21     
+ Misses       6533     6516      -17     
  Partials      822      822              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 02 '24 04:03 codecov[bot]

/retest

Xunzhuo avatar Mar 03 '24 13:03 Xunzhuo