gateway icon indicating copy to clipboard operation
gateway copied to clipboard
verified publisher icon envoyproxy

Replace Status with PolicyAncestorStatus in CTP, BTP and SP

Open arkodg opened this issue 1 year ago • 3 comments

Description:

Describe the issue.

Use the upstream PolicyAncestorStatus definition which creates a top level structure per controller https://gateway-api.sigs.k8s.io/geps/gep-713/#standard-status-struct

instead of what we have today e.g. https://github.com/envoyproxy/gateway/blob/1775624114aedee731bee565a0a100eeee80fc13/api/v1alpha1/backendtrafficpolicy_types.go#L97

Should fix https://github.com/envoyproxy/gateway/issues/2520

arkodg avatar Feb 16 '24 03:02 arkodg

by updating Status in Policies to PolicyAncestorStatus, this will also requires some changes in egctl x status

shawnh2 avatar Feb 28 '24 08:02 shawnh2

should we change it directly to PolicyAncestorStatus or instead consider PolicyStatus which each Ancestors can refer to objects that are either the Target of a policy or above it in terms of object hierarchy, as described in here?

shawnh2 avatar Feb 28 '24 14:02 shawnh2

ah I meant using the struct you referenced PolicyStatus https://github.com/kubernetes-sigs/gateway-api/blob/72f679c7c67228f5b4340e0c2f50cc04b36945b1/apis/v1alpha2/policy_types.go#L187, thanks for clarifying

arkodg avatar Feb 28 '24 21:02 arkodg

blocked on https://github.com/envoyproxy/gateway/issues/2724#issuecomment-1970130948

arkodg avatar Feb 28 '24 23:02 arkodg