gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Improve XDS translator test to remove explicit test case definition

Open UtkarshUmre opened this issue 6 months ago • 1 comments

What type of PR is this?

refactor: Improve XDS translator test to dynamically generate test cases

What this PR does / why we need it:

This PR refactors the XDS translator test to dynamically generate test cases based on input files found in the testdata/xds-ir directory. Instead of explicitly specifying test names and cases within the test function, the code now iterates over input files, treating each file as a separate test case. This approach simplifies the test code, reduces redundancy, and improves maintainability by eliminating the need to specify test names manually.

Which issue(s) this PR fixes:

Fixes #2229

UtkarshUmre avatar Feb 09 '24 10:02 UtkarshUmre

hi @UtkarshUmre, thanks for the contribution, can you fix the ci please?

shawnh2 avatar Feb 15 '24 01:02 shawnh2

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Mar 16 '24 04:03 github-actions[bot]

Since this PR is stale, I will take it from here.

shawnh2 avatar Apr 21 '24 06:04 shawnh2