gateway icon indicating copy to clipboard operation
gateway copied to clipboard

The "run-kube-local" Make Target Causes Incorrect xDS Address

Open danehans opened this issue 2 years ago • 3 comments

The "run-kube-local" Make target causes Envoy to fail to connect to the xDS server, i.e. Envoy Gateway. This is because the Envoy Deployment will use "envoy-gateway" as the DNS name to connect to Envoy Gateway. Since this Service and associated EG Deployment does not exist, Envoy never connects to the xDS server. This Make target should update the xDS address to "host.docker.internal" of the Make target when called.

xref: https://github.com/envoyproxy/gateway/pull/245 xref: https://github.com/envoyproxy/gateway/pull/224

danehans avatar Aug 26 '22 18:08 danehans

imho make run-kube-local should pick a new bootstrap file (which would be supported once https://github.com/envoyproxy/gateway/issues/31 is in) which would contain the updated xDS address host.docker.internal (for non linux systems) it would be a long list of things to support if we starting supporting configuration of individual fields such as the xds server address

arkodg avatar Sep 01 '22 19:09 arkodg

/assign cc @arkodg

Xunzhuo avatar Sep 14 '22 23:09 Xunzhuo

I dont see an easy of doing this w/o adding a new API or supporting Envoy resource configs directly. suggesting moving this in backlog and tackling this later once https://github.com/envoyproxy/gateway/issues/31 is supported

arkodg avatar Sep 23 '22 19:09 arkodg

Agreed. With control plane auth being added, we need to expose the certs dir and have a tool that generates the certs similar to the certgen job:

2022-09-26T17:13:47.105Z	ERROR	runner/runner.go:162	failed to load certificate and key	{"runner": "xds-server", "error": "open /certs/tls.crt: no such file or directory"}

xref: https://envoyproxy.slack.com/archives/C03E6NHLESV/p1664212644662989

danehans avatar Sep 26 '22 18:09 danehans

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 05 '22 12:12 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar Dec 12 '22 12:12 github-actions[bot]