gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Implement liveness and readiness probes on the Deployment

Open skriss opened this issue 2 years ago • 3 comments

There are liveness and readiness probes defined on the envoy-gateway Deployment: https://github.com/envoyproxy/gateway/blob/main/internal/provider/kubernetes/config/envoy-gateway/deploy_and_ns.yaml#L40-L49

However, I don't see any code that implements these, and in my test cluster the pod is not responding to them and therefore not becoming ready / getting restarted regularly.

They need to either be implemented, or removed for now until we're ready to implement them so the pod can at least run.

skriss avatar Aug 24 '22 14:08 skriss

The probe definitions have been temporarily removed in #238 to unblock running EG in cluster but should eventually be re-added and implemented properly.

skriss avatar Aug 24 '22 18:08 skriss

I can help on this, assign this to me plz

Xunzhuo avatar Aug 25 '22 08:08 Xunzhuo

I can help on this, assign this to me plz

Great, thanks @Xunzhuo!

skriss avatar Aug 25 '22 15:08 skriss

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 24 '22 20:09 github-actions[bot]

@Xunzhuo are you still able to help with this issue?

danehans avatar Sep 29 '22 19:09 danehans