envoy
envoy copied to clipboard
envoyproxy
upstream: outlier detection for non 5xx codes
Commit Message: Another attempt to fix #18789 Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/39947 was opened by cpakulski.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/39947 was opened by cpakulski.
@wbpcode I know it has been a long time since you reviewed it last time. I apologize for delay. I addressed most of your comments. I think we reached an agreement on API :-)). If the rest of the code looks good I will add integration and regression tests, docs and it should be ready for final review.
@wbpcode Thanks for approving the API. I added integration tests and updated docs. I believe that it is ready for another review (moving it out of draft).
seems like this needs a maintainer reviewer (wbpcode did the api shepards)
/assign @paul-r-gall
release notes are still needed. I will add them once the PR is ready for merge.
Thanks @paul-r-gall . CI fails now and I am investigating if my changes cause those errors.
@paul-r-gall . CI passes now. I had to do minor adjustment to a namespace in one of the tests.