envoy icon indicating copy to clipboard operation
envoy copied to clipboard

xds: add singleton subscription xDS-TP-based config-sources support

Open adisuissa opened this issue 5 months ago • 2 comments

Commit Message: xds: add singleton subscription xDS-TP-based config-sources support Additional Description: Followup to #39781, as part of #24773. This PR adds the framework for singleton subscriptions to resources that are defined using the xDS-TP config-sources in the bootstrap. Next is to convert the current xDS singletons (EDS, RDS, etc.) to use this functionality.

Risk Level: low - not used Testing: Added unit tests. Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A

Part of #24773.

adisuissa avatar Jun 18 '25 15:06 adisuissa

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/39943 was opened by adisuissa.

see: more, trace.

/assign @nezdolik @tonya11en @yanavlasov

adisuissa avatar Jun 18 '25 20:06 adisuissa

Thanks for the review @nezdolik !

adisuissa avatar Jun 23 '25 13:06 adisuissa

LGTM. Waiting for LGTM from @nezdolik as well.

/wait-any

yanavlasov avatar Jun 23 '25 13:06 yanavlasov

/retest

adisuissa avatar Jun 24 '25 13:06 adisuissa