envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Replace c-ares with getAddrInfo DNS resolver in DFP integration tests

Open yanjunxiang-google opened this issue 5 months ago • 3 comments
trafficstars

Replace c-ares with getAddrInfo DNS resolver in DFP integration tests.

It's the 1st step to address: https://github.com/envoyproxy/envoy/issues/39900

This PR also changed DFP cluster DNS resolver creating behavior to honor default DNS resolver configuration in bootstrap. Such behavior exists for strict and logical DNS clusters as here: https://github.com/envoyproxy/envoy/blob/83b36ea36575d09740cf7b1de909bdc603423212/source/common/upstream/cluster_factory_impl.cc#L106.
The other issue is that currently: DFP sub_cluster_config feature does not support customized DNS resolver configuration as described in https://github.com/envoyproxy/envoy/issues/39694. By honoring bootstrap default DNS resolver here, it also solved that problem. Otherwise, when DFP sub_cluster_config is configured, Envoy always creates c-ares DNS resolver as described in this issue.

yanjunxiang-google avatar Jun 14 '25 16:06 yanjunxiang-google

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/39901 was opened by yanjunxiang-google.

see: more, trace.

/assign @yanavlasov

yanjunxiang-google avatar Jun 16 '25 15:06 yanjunxiang-google

Need format fix.

/wait

yanavlasov avatar Jun 18 '25 15:06 yanavlasov

kind ping

yanjunxiang-google avatar Jun 23 '25 13:06 yanjunxiang-google

@RyanTheOptimist please LGTM if you are good with these changes.

/wait-any

yanavlasov avatar Jun 23 '25 13:06 yanavlasov