envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Fixed upstream filter disabled by default

Open andy-fong opened this issue 5 months ago • 3 comments

Commit Message: Fixed upstream filter disabled by default Additional Description: Fixes https://github.com/envoyproxy/envoy/issues/39587 Risk Level: low Testing: Added tests in the header mutation integration tests to make sure upstream filter can be disabled and re-enabled or vice versa at all config levels. Docs Changes: None Release Notes:

andy-fong avatar Jun 12 '25 21:06 andy-fong

Hi @andy-fong, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/39878 was opened by andy-fong.

see: more, trace.

@paul-r-gall updated base on your comments but I didn't change all the existing EXPECT_EQ. Do I resolve the comments after I push the update or the reviewer will resolve once the change is satisfactory?

andy-fong avatar Jun 17 '25 19:06 andy-fong

The failure seems to be un-related to my change. bazel was failing to download something, so might be transient. Can someone re-run that test?

andy-fong avatar Jun 18 '25 14:06 andy-fong

/retest

paul-r-gall avatar Jun 20 '25 13:06 paul-r-gall