envoy
envoy copied to clipboard
Fixed upstream filter disabled by default
Commit Message: Fixed upstream filter disabled by default Additional Description: Fixes https://github.com/envoyproxy/envoy/issues/39587 Risk Level: low Testing: Added tests in the header mutation integration tests to make sure upstream filter can be disabled and re-enabled or vice versa at all config levels. Docs Changes: None Release Notes:
Hi @andy-fong, welcome and thank you for your contribution.
We will try to review your Pull Request as quickly as possible.
In the meantime, please take a look at the contribution guidelines if you have not done so already.
@paul-r-gall updated base on your comments but I didn't change all the existing EXPECT_EQ. Do I resolve the comments after I push the update or the reviewer will resolve once the change is satisfactory?
The failure seems to be un-related to my change. bazel was failing to download something, so might be transient. Can someone re-run that test?
/retest