envoy icon indicating copy to clipboard operation
envoy copied to clipboard

redis: fix segfault at cluster removing

Open keyolk opened this issue 5 months ago • 4 comments
trafficstars

It is about to fix https://github.com/envoyproxy/envoy/issues/38585

No much idea about both envoy and c++ But it solves my problem Plz review and guide me

keyolk avatar May 26 '25 06:05 keyolk

Hi @keyolk, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/39625 was opened by keyolk.

see: more, trace.

Please add a test and check CI, thanks.

/wait

mattklein123 avatar May 27 '25 15:05 mattklein123

@mathetake I'm trying, but it seems I can't build the latest envoy revision on my laptop. Don't know why it consumes more than 30 GB to build since 1.34. Do you think it is ok to test it rebasing with 1.33?

keyolk avatar Jun 04 '25 01:06 keyolk

@keyolk sorry unfortunately you have to fix it on the main branch

/wait

mathetake avatar Jun 16 '25 10:06 mathetake

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jul 16 '25 12:07 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jul 23 '25 12:07 github-actions[bot]