envoy icon indicating copy to clipboard operation
envoy copied to clipboard

http3: Change Envoy's HTTP/3 implementation to validate pseudo headers

Open RyanTheOptimist opened this issue 6 months ago • 11 comments
trafficstars

Can be disabled by setting envoy.restart_features.validate_http3_pseudo_headers to false.

RyanTheOptimist avatar May 23 '25 18:05 RyanTheOptimist

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/39615 was opened by RyanTheOptimist.

see: more, trace.

/assign @yanavlasov

RyanTheOptimist avatar May 23 '25 18:05 RyanTheOptimist

/retest

RyanTheOptimist avatar May 23 '25 19:05 RyanTheOptimist

Needs format fixes.

/wait

yanavlasov avatar Jun 03 '25 15:06 yanavlasov

LGTM. The "prime bazel cache" jobs are failing hard. Not sure if it needs main merge or not. @phlax might have an idea.

yanavlasov avatar Jun 12 '25 14:06 yanavlasov

/wait-any

yanavlasov avatar Jun 12 '25 14:06 yanavlasov

merge main will fix

phlax avatar Jun 12 '25 14:06 phlax

merge main will fix

Merged!

RyanTheOptimist avatar Jun 12 '25 14:06 RyanTheOptimist

Spellchecker is not happy with pseudoheaders

yanavlasov avatar Jun 12 '25 15:06 yanavlasov

/wait

yanavlasov avatar Jun 12 '25 15:06 yanavlasov

@yanavlasov Ok, sorry for the churn. This is finally green!

RyanTheOptimist avatar Jun 18 '25 21:06 RyanTheOptimist