go control plane missing month/year rate limiting enums

[rpahli]

how to generate the missing enums for the go control plane

We want to use the new ratelimit enums but the are currently not part of the go control plane code. How is the release process for the generated code?

go-controle-plane issue envoy gateway issue

[kyessenov]

I see it there https://github.com/envoyproxy/go-control-plane/blob/main/envoy/service/ratelimit/v3/rls.pb.go#L100. The Go bindings are auto-generated and pushed immediately with new API changes. Maybe you need to update your version of go-control-plane?

[commoddity]

I see it there https://github.com/envoyproxy/go-control-plane/blob/main/envoy/service/ratelimit/v3/rls.pb.go#L100. The Go bindings are auto-generated and pushed immediately with new API changes. Maybe you need to update your version of go-control-plane?

Thanks for the response.

MONTH and YEAR are present in the file you mentioned but appear to be missing in this file:

• https://github.com/envoyproxy/go-control-plane/blob/main/ratelimit/config/ratelimit/v3/rls_conf.pb.go

Which says it is generated from the proto file (which does contain MONTH and YEAR):

• https://github.com/envoyproxy/ratelimit/blob/main/api/ratelimit/config/ratelimit/v3/rls_conf.proto

In Envoy Gateway's usage, the type RateLimitUnit must be used for the field RateLimitPolicy.Unit, and is only present in rls_conf.pb.go and not in rls.pb.go.

[kyessenov]

Oh, I see, this is pulled from the separate envoyproxy/ratelimit project, rather than the main envoyproxy/envoy. It appears this was done manually in https://github.com/envoyproxy/go-control-plane/pull/598.

CC @renuka-fernando @alecholmez

[commoddity]

Oh, I see, this is pulled from the separate envoyproxy/ratelimit project, rather than the main envoyproxy/envoy. It appears this was done manually in envoyproxy/go-control-plane#598.

CC @renuka-fernando @alecholmez

@kyessenov I'm curious if you have any updates on this enum being added to the go-control-plane module. I believe it's currently the only blocker to adding the ability to rate limit by MONTH and YEAR to Envoy Gateway, as stated in the PR that @rpahli is currently working on.

If it's not possible for someone on your team to add the missing enum, would it be possible to provide more details on the proto generation and/or release process so that I could perhaps try and open a PR myself?

[Olshansk]

Just wanted to add (on behalf of @buildwithgrove) that we really appreciate how quickly you guys are building and iterating.

We're going to adopt this in production literally as soon as its ready :)

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

[renuka-fernando]

Oh, I see, this is pulled from the separate envoyproxy/ratelimit project, rather than the main envoyproxy/envoy. It appears this was done manually in https://github.com/envoyproxy/go-control-plane/pull/598.

CC @renuka-fernando @alecholmez

This is done manually. @alecholmez can't we automate this?

[Olshansk]

@rpahli Are there any updates on this issue?

[rpahli]

solved with https://github.com/envoyproxy/go-control-plane/pull/1223