envoy icon indicating copy to clipboard operation
envoy copied to clipboard

stats: add tag extraction rules for ADS disconnections

Open grnmeira opened this issue 1 year ago • 1 comments

Commit Message: adds tag extraction rules for envoy.ads_cluster.streams_closed. Additional Description: as seen on #21595 Risk Level: low Testing: removes skip_tag_extraction_rule_check_ from ADS integration tests. Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

grnmeira avatar Oct 17 '24 12:10 grnmeira

Maybe @adisuissa can help to review this PR, as xDS expert.

tyxia avatar Oct 18 '24 16:10 tyxia

/wait

adisuissa avatar Oct 21 '24 19:10 adisuissa

@adisuissa please let me know if you're happy with my changes. All CI checks passing now.

grnmeira avatar Oct 31 '24 12:10 grnmeira

friendly ping @adisuissa . PTAL

KBaichoo avatar Nov 05 '24 15:11 KBaichoo