envoy icon indicating copy to clipboard operation
envoy copied to clipboard

mobile: add knob for h3 keepalive

Open danzh2010 opened this issue 1 year ago • 11 comments

Commit Message: add a config knob to Java, Kotlin and C++ engines to set initial interval of QUIC keepalive probing.

Additional Description: also adjust the validation rule of initial_interval to be larger than 1ms instead of 1s and fix contradicting documentation.

Risk Level: low, interface change Testing: unit test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A

danzh2010 avatar Oct 16 '24 15:10 danzh2010

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @abeyad CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/36646 was opened by danzh2010.

see: more, trace.

test failures look legit though, e.g. https://github.com/envoyproxy/envoy/actions/runs/11369001000/job/31625515074

abeyad avatar Oct 16 '24 17:10 abeyad

no relevant owners for "mobile"

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/36646#pullrequestreview-2373219194 was submitted by @abeyad.

see: more, trace.

/assign @alyssawilk

since it contains core code, Alyssa should merge

abeyad avatar Oct 16 '24 17:10 abeyad

/retest

danzh2010 avatar Oct 16 '24 17:10 danzh2010

/retest

danzh2010 avatar Oct 16 '24 22:10 danzh2010

/wait-any on CI

alyssawilk avatar Oct 17 '24 12:10 alyssawilk

/retest

danzh2010 avatar Oct 17 '24 16:10 danzh2010

/assign @envoyproxy/api-shepherds

danzh2010 avatar Oct 17 '24 17:10 danzh2010

@envoyproxy/api-shepherds cannot be assigned to this issue.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/36646#issuecomment-2420148418 was created by @danzh2010.

see: more, trace.

@alyssawilk and @abeyad, PTAL again!

danzh2010 avatar Oct 17 '24 17:10 danzh2010