envoy icon indicating copy to clipboard operation
envoy copied to clipboard

router: remove send_local_reply_when_no_buffer_and_upstream_request guard

Open botengyao opened this issue 1 year ago • 5 comments

Commit Message: router: remove send_local_reply_when_no_buffer_and_upstream_request guard Risk Level: low Testing: unit test Docs Changes: Fixes #36609

botengyao avatar Oct 15 '24 19:10 botengyao

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/36620 was opened by botengyao.

see: more, trace.

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/36620 was opened by botengyao.

see: more, trace.

/assign @alyssawilk

botengyao avatar Oct 15 '24 20:10 botengyao

/retest

botengyao avatar Oct 16 '24 19:10 botengyao

/retest

alyssawilk avatar Oct 17 '24 12:10 alyssawilk