envoy icon indicating copy to clipboard operation
envoy copied to clipboard

wasm: remove redundant xds attributes

Open kyessenov opened this issue 1 year ago • 7 comments

Change-Id: I152e259f3f8e5f69463a64fedce4181ce606824b

Commit Message: Remove attributes that were marked as deprecated in https://github.com/envoyproxy/envoy/commit/ff991f3454b426bfec49c752d1e7ffbafa9fdd76. This improves the alignment of get_property ABI with the generic attribute support in Envoy in CEL, for example, and simplifies the implementation.

Additional Description: Risk Level: low, experimental filter, advanced warning to stop using attributes was given Testing: updated Docs Changes: yes Release Notes: yes

kyessenov avatar Oct 15 '24 19:10 kyessenov

/coverage

kyessenov avatar Oct 16 '24 16:10 kyessenov

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/36619/coverage/index.html

The coverage results are (re-)rendered each time the CI envoy-presubmit (check linux_x64 coverage) job completes.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/36619#issuecomment-2417283691 was created by @kyessenov.

see: more, trace.

/assign @mpwarres, based on CODEOWNER

tyxia avatar Oct 16 '24 19:10 tyxia

neither of @mpwarres,, based, on, CODEOWNER can be assigned to this issue.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/36619#issuecomment-2417685165 was created by @tyxia.

see: more, trace.

/assign @mpwarres

based on CODEOWNER

tyxia avatar Oct 16 '24 19:10 tyxia

Side note: @kyessenov @alyssawilk looks like WSAM doesn't have maintainer sponsor currently given Lizan has left? https://github.com/envoyproxy/envoy/blob/main/CODEOWNERS#L106-L116

tyxia avatar Oct 16 '24 19:10 tyxia

I'm willing to sponsor the improvements to Wasm, as previously discussed.

kyessenov avatar Oct 16 '24 19:10 kyessenov